Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA - Sécurité] Alerte github historique #2532

Merged
merged 2 commits into from
May 13, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented May 3, 2024

Ticket

#2531

Description

  • Suppression d'une partie du code qui semble inutilisé et qui contenait la faille de sécurité

Tests

  • Vérifier que la route back_signalement_switch_value n'avait pas d'autre utilité que l'ajout/retrait de tag

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK dans le périmètre du ticket

Suite aux tests

  • Proposition d'amélioration UX
    • Ajouter un curseur pointer sur le badges de tags
  • Test
    • Ajout d'un test sur la route signalement_switch_value_

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et tests OK pour moi aussi.
D'accord avec les améliorations proposées par Saidi !

@numew numew force-pushed the feature/2531-alert-gthub-security branch from 0238a4f to 78451d6 Compare May 7, 2024 15:03
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi

@hmeneuvrier hmeneuvrier merged commit d3885c5 into develop May 13, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the feature/2531-alert-gthub-security branch June 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants